allow api_key to be positional #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it doesn't make sense that if someone creates a client without any kwargs, it writes their first positional parameter as the base_url, which users will rarely, if ever, change. by making api_key a positional argument, the user can create the ApiClient object without kwargs. eg NotificationsAPIClient(my_api_key). this is a breaking change if users were originally calling without keywords, as api_key now preceeds base_url.
leohemsted
force-pushed
the
client-params
branch
from
79c26a1 to
84c3ee4
Compare
servingUpAces
approved these changes
Nov 14, 2016
|
Thanks! 👍 ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow user to say
NotificationAPIClient(foo)instead of...(api_key=foo)(since thats what we say in our docs, and it makes sense)also removed monotonic as dependency.
this is a breaking change
check if any other teams are using python client and if this would break their usage